fix: optimise augmented reality #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donni106
requested changes
Aug 3, 2023
ardasnturk
force-pushed
the
fix/SVA-1073-optimise-augmented-reality
branch
from
71b3f00
to
c29fee6
Compare
- added `totalMemory` value to `device.js` to see the `RAM` information of the device and used `totalMemory` in `expo-device` package - added `GB_TO_BYTES` section to `consts.js` because the `totalMemory` property gives us RAM in bytes and therefore we need to know gb in bytes - removed `spot` and `quad` (shadow) to optimise AR for devices with less than 2 gb of RAM SVA-1073
ardasnturk
force-pushed
the
fix/SVA-1073-optimise-augmented-reality
branch
from
c29fee6
to
a345a69
Compare
donni106
approved these changes
Aug 3, 2023
d4v3d4vE
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
totalMemoryvalue todevice.jsto see theRAMinformation of the device and usedtotalMemoryinexpo-devicepackageGB_TO_BYTESsection toconsts.jsbecause thetotalMemoryproperty gives us RAM in bytes and therefore we need to know gb in bytesspotandquad(shadow) to optimise AR for devices with less than 2 gb of RAMSVA-1073